Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes Issue 2306: make Informers work with KubernetesServer CRUD mode #2396

Merged
merged 2 commits into from
Aug 20, 2020

Conversation

lalithsuresh
Copy link
Contributor

@lalithsuresh lalithsuresh commented Aug 10, 2020

Description

Fixes #2306: make Informers work with KubernetesServer CRUD mode

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Checklist

  • Code contributed by me aligns with current project license: Apache 2.0
  • I Added CHANGELOG entry regarding this change
  • I have implemented unit tests to cover my changes
  • I have added/updated the javadocs and other documentation accordingly
  • No new bugs, code smells, etc. in SonarCloud report
  • I tested my code in Kubernetes
  • I tested my code in OpenShift

@centos-ci
Copy link

Can one of the admins verify this patch?

@lalithsuresh
Copy link
Contributor Author

Rebasing against master (e8c47dc) to avoid merge conflict in CHANGELOG.md

@lalithsuresh
Copy link
Contributor Author

May I know why the license check is failing? The logs don't reveal why.

@devang-gaur
Copy link
Contributor

Not sure If I'm right here but if we're adding informers support to the crud mock server.. shouldn't we also update the resourceVersion of the resource when it's updated?

…mers

This is addressed by making sure that MockWebServer returns a metadata object
for list queries.

Signed-off-by: Lalith Suresh <lsuresh@vmware.com>
Signed-off-by: Lalith Suresh <lsuresh@vmware.com>
@sonarcloud
Copy link

sonarcloud bot commented Aug 18, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@manusa
Copy link
Member

manusa commented Aug 20, 2020

[merge]

@fusesource-ci fusesource-ci merged commit 3a6587f into fabric8io:master Aug 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

KubernetesServer CRUD mode and informers
7 participants